cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

forgejo: Always return a response and its body.

Browse source 
Fixes the bug reported in
<https://codeberg.org/guix/maintenance/pulls/18#issuecomment-5851510>.

Previously ‘forgejo-controller’ would return a single value in
successful cases, whichever ‘enqueue-job-for-pull-request’ or
‘mark-pull-request-branch-for-deletion’ would return.
This commit is contained in:
Ludovic Courtès 2025-07-16 19:11:33 +02:00
parent 2e91f31559
commit b35c26a74e
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
guix-data-service/web/forgejo/controller.scm
View file

@ -70,11 +70,14 @@
(lambda (conn) (lambda (conn)
(match action (match action
((or 'opened 'reopened) ;new pull request ((or 'opened 'reopened) ;new pull request
(enqueue-job-for-pull-request conn pull-request)) (enqueue-job-for-pull-request conn pull-request)
(render-json '() #:code 200))
('synchronized ;pull request is updated ('synchronized ;pull request is updated
(enqueue-job-for-pull-request conn pull-request)) (enqueue-job-for-pull-request conn pull-request)
(render-json '() #:code 200))
('closed ;closed or merged ('closed ;closed or merged
(mark-pull-request-branch-for-deletion conn pull-request)) (mark-pull-request-branch-for-deletion conn pull-request)
(render-json '() #:code 200))
(_ ;other action (_ ;other action
(render-json '((error . "unknown action")) (render-json '((error . "unknown action"))
#:code 404))))))) #:code 404)))))))