From b35c26a74e9458b9d0756503aeef916184c7e871 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= Date: Wed, 16 Jul 2025 19:11:33 +0200 Subject: [PATCH] forgejo: Always return a response and its body. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes the bug reported in . Previously ‘forgejo-controller’ would return a single value in successful cases, whichever ‘enqueue-job-for-pull-request’ or ‘mark-pull-request-branch-for-deletion’ would return. --- guix-data-service/web/forgejo/controller.scm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/guix-data-service/web/forgejo/controller.scm b/guix-data-service/web/forgejo/controller.scm index 28df2f6..3fa2965 100644 --- a/guix-data-service/web/forgejo/controller.scm +++ b/guix-data-service/web/forgejo/controller.scm @@ -70,11 +70,14 @@ (lambda (conn) (match action ((or 'opened 'reopened) ;new pull request - (enqueue-job-for-pull-request conn pull-request)) + (enqueue-job-for-pull-request conn pull-request) + (render-json '() #:code 200)) ('synchronized ;pull request is updated - (enqueue-job-for-pull-request conn pull-request)) + (enqueue-job-for-pull-request conn pull-request) + (render-json '() #:code 200)) ('closed ;closed or merged - (mark-pull-request-branch-for-deletion conn pull-request)) + (mark-pull-request-branch-for-deletion conn pull-request) + (render-json '() #:code 200)) (_ ;other action (render-json '((error . "unknown action")) #:code 404)))))))