Commit graph

66 commits

Author SHA1 Message Date
e8e1459769 URI encode some derivation names in links
To handle characters like +.
2023-09-07 11:14:11 +01:00
6e4d436d75 Fix some uses of select-build-server-urls-by-id 2023-07-20 16:12:00 +01:00
7251c7d653 Stop using a pool of threads for database operations
Now that squee cooperates with suspendable ports, this is unnecessary. Use a
connection pool to still support running queries in parallel using multiple
connections.
2023-07-10 18:56:31 +01:00
044a905c1d Provide more information about revision processing errors
In the compare package derivations response.
2023-06-15 11:36:46 +01:00
68850065d7 Extend the invalid parameter handling for more types 2023-05-22 17:34:39 +01:00
5f21458a8f Have render-compare/package-derivations provide invalid param info
So that this can be used by the qa-frontpage.

This should be improved and generalised.
2023-05-22 17:25:44 +01:00
Leo Famulari
8c2f97eef8 Comparing package derivations: Fix inconsistent verbage.
Harmonize "Build change" options between the selection menu and the
documentation

* guix-data-service/web/compare/html.scm (compare/package-derivations):
Replace "Still broken" with "Still failing" in the "Build change" help text.

Signed-off-by: Christopher Baines <mail@cbaines.net>
2023-02-17 17:10:52 +00:00
f68822cad2 Include some useful numbers on the package derivations comparison
As it's frequently useful to know how many packages/builds some change has
affected.
2023-02-15 15:48:45 +00:00
9fc5821180 Include more information about invalid query parameters
In the /compare response.

This should enable qa.guix.gnu.org to detect when the base revision for a
comparison is unknown.
2022-11-17 16:18:28 +00:00
1043b51bff Include lint warnings in the JSON /compare response 2022-08-22 17:42:37 +01:00
752d21ad05 Improve the way the field fields work on various pages
Remove the brackets from the values since this makes the set of values more
consistent, and don't display the no additional fields value on the page.
2022-01-31 20:25:06 +00:00
Luciana Lima Brito
767e60b2b3 Change data handling when comparing derivations
comparison.scm: return query data for derivation comparison as an alist,
instead of list.
html.scm: Access derivation differences data using assq-ref.
controller.scm: remove mapping for outputs/inputs/sources.
utils.scm: add group-to-alist/vector function.

Signed-off-by: Christopher Baines <mail@cbaines.net>
2021-04-27 21:18:51 +01:00
Canan Talayhan
fe97021cd0 Set more informative page titles
For many pages where previously the title was just "Guix Data Service".

Signed-off-by: Christopher Baines <mail@cbaines.net>
2021-04-23 12:00:03 +01:00
6387f1bc67 Fetch the list of system values from the database
This removes the need to hardcode some values in the code.
2021-04-23 11:20:36 +01:00
Luciana Brito
a498433643 Implement basic JSON output for the derivation comparison page
Signed-off-by: Christopher Baines <mail@cbaines.net>
2021-04-19 20:53:46 +01:00
39f52e3a2e Update parse-commit for the guix-revision changes 2021-02-04 10:28:04 +00:00
6195d7b18f Remove store_path from select-guix-revision-for-branch-and-datetime
As I want to remove the field from the database.
2021-02-02 19:49:09 +00:00
a88e9db1ff Fix issue with the system test comparison page 2021-01-14 20:44:41 +00:00
1050070067 Implement compare by datetime for system test derivations
Also fix some general issues with the rendering.
2021-01-04 22:59:28 +00:00
6f89066355 Support comparing revision system test derivations
This should come in useful for testing patches, as you can see what system
tests are affected, and check the build status.
2021-01-04 19:15:01 +00:00
c12959330b Include the revision details for package dervation comparisons
I'm wanting the commits for tagging builds.
2020-12-20 19:37:36 +00:00
Leo Famulari
0813ad6978
Tell the user how to specify a datetime.
Also correct a mistake in the error message for invalid datetime formats.
2020-12-19 17:47:53 -05:00
de3ca9d074 Improve the parse-commit invalid parameter handling 2020-11-28 19:36:47 +00:00
8f702e5666 Add system and target controls to the package derivation comparison
By datetime, as these parameters are supported.
2020-11-25 21:05:32 +00:00
56c786e309 Fix typo with build_change parameter
For the compare by datetime package derivations page.
2020-11-21 21:23:39 +00:00
e93da1ae8f Fix the JSON link on the compare package derivations page 2020-11-21 21:10:33 +00:00
7e1cba3309 Consolidate the package derivation comparison code 2020-11-21 21:00:40 +00:00
0c3e208a83 Start merging the package derivation comparison code 2020-11-21 20:29:14 +00:00
56983eb03e Extract out the compare form controls
So they can be used for the package derivations page
2020-11-21 20:25:26 +00:00
814a5d7cba Fix some links on the compare page 2020-11-21 20:11:21 +00:00
12f35c493b Add default datetimes for compare-by-datetime
As this makes it easy to compare the current state of two branches.
2020-11-21 20:11:21 +00:00
7321ce4408 Improve the comparison page interface
Try to unify the code for the different comparison modes, so that there's less
of it.
2020-11-21 18:37:19 +00:00
c751031a26 Avoid crashing when no compare arguments are provided 2020-11-21 16:49:58 +00:00
00c84640c5 Improve the headings on the compare derivations page 2020-11-20 19:37:12 +00:00
65507aaac1 Don't show all results on the compare package derivation page
By default. For comparisons involving lots of changed derivations, the page
can take too long to render.
2020-11-20 19:33:16 +00:00
d98c676563 Fix typo 2020-11-19 21:46:47 +00:00
ce73e4448d Include a "Build change" filter on the package derivations page
This helps determine what things a change broke or fixed for example.
2020-11-19 21:02:47 +00:00
80c6fbd1ac Clean up some unused code in the compare controller 2020-11-19 20:59:02 +00:00
1431f712a6 Fix compare by datetime URL
Use package-derivations rather than derivations, as this is more accurate.
2020-11-19 20:58:38 +00:00
e394d1d6ad Show build information when comparing package derivations
As this is useful to see, as it can indicate that a change to the derivation
has led to the builds to start failing/succeeding.
2020-10-31 15:55:11 +00:00
1573fe566b Remove a few peek calls that snuck in 2020-10-31 15:54:34 +00:00
c05cbd8438 Rename some derivation comparison procedures
As they actually just relate to package derivations.
2020-10-31 13:52:08 +00:00
6c47212c4d Improve the failed comparison page 2020-10-23 16:23:16 +01:00
faa32234d8 Fix compare package derivations JSON link 2020-10-23 12:47:43 +01:00
2fa9f151f6 Include the base commit and target commit in the compare output
This makes it easier to make other requests with the response body.
2020-10-09 19:35:38 +01:00
6023aa8caf Improve select-job-for-commit
It now returns #f or a list, rather than the empty list or a nested list.
2020-10-09 19:31:51 +01:00
51204aefca Clarify that the derivations comparison only is for packages
As it excludes the channel instances and system tests.
2020-10-09 19:31:21 +01:00
853aaa6a7c Use letpar& for systems and targets in render-compare/derivations 2020-10-09 19:30:48 +01:00
8daf35e2df Change the derivation comparison targets
To be targets, rather than systems.
2020-10-09 19:29:58 +01:00
1f55718d75 Link to the revisions in the comparison header 2020-10-09 19:29:38 +01:00