Commit graph

42 commits

Author SHA1 Message Date
56c786e309 Fix typo with build_change parameter
For the compare by datetime package derivations page.
2020-11-21 21:23:39 +00:00
e93da1ae8f Fix the JSON link on the compare package derivations page 2020-11-21 21:10:33 +00:00
7e1cba3309 Consolidate the package derivation comparison code 2020-11-21 21:00:40 +00:00
0c3e208a83 Start merging the package derivation comparison code 2020-11-21 20:29:14 +00:00
56983eb03e Extract out the compare form controls
So they can be used for the package derivations page
2020-11-21 20:25:26 +00:00
814a5d7cba Fix some links on the compare page 2020-11-21 20:11:21 +00:00
12f35c493b Add default datetimes for compare-by-datetime
As this makes it easy to compare the current state of two branches.
2020-11-21 20:11:21 +00:00
7321ce4408 Improve the comparison page interface
Try to unify the code for the different comparison modes, so that there's less
of it.
2020-11-21 18:37:19 +00:00
c751031a26 Avoid crashing when no compare arguments are provided 2020-11-21 16:49:58 +00:00
00c84640c5 Improve the headings on the compare derivations page 2020-11-20 19:37:12 +00:00
65507aaac1 Don't show all results on the compare package derivation page
By default. For comparisons involving lots of changed derivations, the page
can take too long to render.
2020-11-20 19:33:16 +00:00
d98c676563 Fix typo 2020-11-19 21:46:47 +00:00
ce73e4448d Include a "Build change" filter on the package derivations page
This helps determine what things a change broke or fixed for example.
2020-11-19 21:02:47 +00:00
80c6fbd1ac Clean up some unused code in the compare controller 2020-11-19 20:59:02 +00:00
1431f712a6 Fix compare by datetime URL
Use package-derivations rather than derivations, as this is more accurate.
2020-11-19 20:58:38 +00:00
e394d1d6ad Show build information when comparing package derivations
As this is useful to see, as it can indicate that a change to the derivation
has led to the builds to start failing/succeeding.
2020-10-31 15:55:11 +00:00
1573fe566b Remove a few peek calls that snuck in 2020-10-31 15:54:34 +00:00
c05cbd8438 Rename some derivation comparison procedures
As they actually just relate to package derivations.
2020-10-31 13:52:08 +00:00
6c47212c4d Improve the failed comparison page 2020-10-23 16:23:16 +01:00
faa32234d8 Fix compare package derivations JSON link 2020-10-23 12:47:43 +01:00
2fa9f151f6 Include the base commit and target commit in the compare output
This makes it easier to make other requests with the response body.
2020-10-09 19:35:38 +01:00
6023aa8caf Improve select-job-for-commit
It now returns #f or a list, rather than the empty list or a nested list.
2020-10-09 19:31:51 +01:00
51204aefca Clarify that the derivations comparison only is for packages
As it excludes the channel instances and system tests.
2020-10-09 19:31:21 +01:00
853aaa6a7c Use letpar& for systems and targets in render-compare/derivations 2020-10-09 19:30:48 +01:00
8daf35e2df Change the derivation comparison targets
To be targets, rather than systems.
2020-10-09 19:29:58 +01:00
1f55718d75 Link to the revisions in the comparison header 2020-10-09 19:29:38 +01:00
c3c9c07f9a Completely rework the way db connections are handled during requests
Previously, a connection was passed through the code handling the
request. When queries were performed, this could block the thread though,
potentially leaving the server unable to serve other requests.

Instead, this now runs queries in a pool of threads. This should remove the
possibility of blocking the threads used by the web server, and in doing so,
some of the queries have been parallelised.

I''m still not sure about the naming and syntax, but I think the functionality
is a sort of step forward.
2020-10-03 21:35:31 +01:00
53341c70fc Change the locale codeset representation
From the normalized one, to the one actually contained within glibc. Recent
versions of glibc also contain symlinks linking the normalized codeset to the
locales with the .UTF-8 ending, but older ones do not.

Maybe handling codeset normalisation for queries would be good, but the locale
values ending in .UTF-8 are more compatible and allow the code to be
simplified. For querying, maybe there should be a locales table which handles
different representations.
2020-09-26 11:45:57 +01:00
Danjela Lura
d3096de655 Use lint checker related translations on some pages
Signed-off-by: Christopher Baines <mail@cbaines.net>
2020-06-07 20:17:03 +01:00
374dc25440 Improve system and target query parameter handling 2020-02-13 23:11:59 +00:00
704f149645 Improve the compare-invalid-parameters messages 2020-01-18 10:18:17 +00:00
75665e3203 Fix a few list styling issues 2020-01-02 21:18:42 +00:00
83c86431ae Better split up the comparision functionality
The packages comparison was getting confused by differences in the
derivations, so split the data used to make the comparison more sensible.

This resolves an issue comparing 8dd723f5… and 365892e9… which coinsided with
the fix for importing foreign architecture derivations, meaning that a whole
lot of new derivations appeared in the database. Prior to these changes, it
appeared like every package was new, and with these changes, the list is more
sensible.
2020-01-02 20:41:24 +00:00
5fc23d788d Expand compare by datetime output
Include the commit and datetime for the revisions that were compared.
2019-11-21 20:50:54 +00:00
23f60a6bbb Include news entries on the comparison page 2019-11-21 19:56:19 +00:00
5d7dadc9fe Add more links to store items
On the formatted derivation and derivation comparison pages.
2019-11-21 19:54:54 +00:00
78e830d91e Link to derivation comparison page from the compare/derivations page 2019-11-21 19:54:54 +00:00
e31f370de0 Add a basic derivation comparison page 2019-11-21 19:54:54 +00:00
edb21317a6 Remove a couple of peek calls that snuck in 2019-11-21 19:54:54 +00:00
5e2bc7c6e9 Fix various warnings relating to the controller refactoring 2019-10-18 18:44:42 +01:00
263eb0e0a9 Handle unknown requests better within controllers 2019-10-18 17:23:59 +01:00
4ce8d9e830 Extract the comparison pages out from the main modules
In to their own modules. This should help make the code more understandable,
and allow future refactoring for readability.
2019-10-14 19:24:14 +01:00