cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Skip the derivation linter

Browse source 
And remove the chunking of derivation lint warnings.

The derivation linter computes the derivation for each packages supported
systems, but there are two problems with the approach. By doing this for each
package in turn, it forces inefficient uses of caches, since most of the
cached data is only relevant to a single system. More importantly though,
because the work of checking one package is dependent on it's supported
systems, it's unpredictable how much work will happen, and this will tend to
increase as more packages support more systems.

I think especially because of this last point, it's not worth attempting to
keep running the derivation linter at the moment, because it doesn't seem
sustainable. I can't see an way to run it that's futureproof and won't break
at some point in the future when packages in Guix support more systems.
This commit is contained in:
Christopher Baines 2022-11-24 10:42:44 +00:00
parent 7ae1c97b92
commit ff6f87a3b9
1 changed files with 12 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

32
guix-data-service/jobs/load-new-guix-revision.scm
View file

@ -643,27 +643,19 @@ WHERE job_id = $1")
((name description network-dependent?) ((name description network-dependent?)
(cons (cons
(list name description network-dependent?) (list name description network-dependent?)
(if network-dependent? (if (or network-dependent?
(eq? name 'derivation))
'() '()
(with-time-logging (simple-format #f "getting ~A lint warnings" (let ((warnings
name) (with-time-logging (simple-format #f "getting ~A lint warnings"
(let loop ((packages-chunks name)
(chunk packages 3000)) (inferior-eval-with-store
(warnings '())) inf
store
(if (null? packages-chunks) (lint-warnings-for-checker packages
warnings name)))))
(let ((new-warnings (cleanup-inferior inf)
(inferior-eval-with-store warnings)))))
inf
store
(lint-warnings-for-checker (car packages-chunks)
name))))
(cleanup-inferior inf)
(loop (cdr packages-chunks)
(append! warnings
new-warnings))))))))))
checkers)))) checkers))))
(define (all-inferior-package-derivations store inf packages) (define (all-inferior-package-derivations store inf packages)