cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Say that there are no lint warnings

Browse source 
Rather than having an empty table.
This commit is contained in:
Christopher Baines 2020-03-21 11:01:16 +00:00
parent e108ed34e2
commit e18f3861f8
1 changed files with 48 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

88
guix-data-service/web/revision/html.scm
View file

@ -280,46 +280,54 @@
(th "Message") (th "Message")
(th "Location"))) (th "Location")))
(tbody (tbody
,@(map ,@(if (null? lint-warnings)
(match-lambda `((tr
((id lint-checker-name lint-checker-description (td (@ (colspan 3)
lint-checker-network-dependent (align "center"))
file line-number column-number "No lint warnings "
message) (span
`(tr (@ (class "label label-success"))
(td (span (@ (style "font-family: monospace; display: block;")) "✓"))))
,lint-checker-name) (map
(p (@ (style "font-size: small; margin: 6px 0 0px;")) (match-lambda
,lint-checker-description)) ((id lint-checker-name lint-checker-description
(td ,message) lint-checker-network-dependent
(td file line-number column-number
,@(if (and file (not (string-null? file))) message)
`((ul `(tr
(@ (class "list-unstyled")) (td (span (@ (style "font-family: monospace; display: block;"))
,@(map ,lint-checker-name)
(match-lambda (p (@ (style "font-size: small; margin: 6px 0 0px;"))
((id label url cgit-url-base) ,lint-checker-description))
(let ((output (td ,message)
`(,file (td
" " ,@(if (and file (not (string-null? file)))
(span `((ul
(@ (style "white-space: nowrap")) (@ (class "list-unstyled"))
"(line: " ,line-number ,@(map
", column: " ,column-number ")")))) (match-lambda
(if ((id label url cgit-url-base)
(and cgit-url-base (let ((output
(not (string-null? cgit-url-base))) `(,file
`(li " "
(a (@ (href (span
,(string-append (@ (style "white-space: nowrap"))
cgit-url-base "tree/" "(line: " ,line-number
file "?id=" revision-commit-hash ", column: " ,column-number ")"))))
"#n" line-number))) (if
,@output)) (and cgit-url-base
`(li ,@output))))) (not (string-null? cgit-url-base)))
git-repositories))) `(li
'()))))) (a (@ (href
lint-warnings))))))))) ,(string-append
cgit-url-base "tree/"
file "?id=" revision-commit-hash
"#n" line-number)))
,@output))
`(li ,@output)))))
git-repositories)))
'())))))
lint-warnings))))))))))
(define (view-revision/git-repositories git-repositories-and-branches (define (view-revision/git-repositories git-repositories-and-branches
commit-hash) commit-hash)