cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change select-required-builds-that-failed to exclude succeeded builds

Browse source 
Only include a failed build if that build server hasn't had any success
building that output. The Guix Build Coordinator can build one output with
many different builds, so this helps avoid showing lots of spurious failures.
This commit is contained in:
Christopher Baines 2020-07-13 18:55:50 +01:00
parent 745a8bdbf1
commit a1af644310
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
guix-data-service/model/build.scm
View file

@ -371,7 +371,17 @@ LEFT OUTER JOIN (
ORDER BY build_id, id DESC ORDER BY build_id, id DESC
) AS latest_build_status ) AS latest_build_status
ON builds.id = latest_build_status.build_id ON builds.id = latest_build_status.build_id
WHERE latest_build_status.status = 'failed'") WHERE latest_build_status.status = 'failed'
AND NOT EXISTS (
SELECT 1
FROM builds AS successful_builds
INNER JOIN build_status AS successful_builds_build_status
ON successful_builds.id = successful_builds_build_status.build_id
WHERE successful_builds.derivation_output_details_set_id =
builds.derivation_output_details_set_id
AND successful_builds.build_server_id = $2
AND successful_builds_build_status.status = 'succeeded'
)")
(exec-query conn (exec-query conn
query query