Support querying builds by build servers

This commit is contained in:
Christopher Baines 2019-12-01 22:18:00 +00:00
parent f7069456b5
commit a0ce016c02
3 changed files with 60 additions and 12 deletions

View file

@ -28,7 +28,24 @@ ORDER BY status")
(exec-query conn query)) (exec-query conn query))
(define (select-builds-with-context conn build-statuses) (define (select-builds-with-context conn build-statuses build-server-ids)
(define where-conditions
(filter
string?
(list
(when (list? build-statuses)
(string-append
"latest_build_status.status IN ("
(string-join (map quote-string build-statuses)
",")
")"))
(when (list? build-server-ids)
(string-append
"builds.build_server_id IN ("
(string-join (map number->string build-server-ids)
", ")
")")))))
(define query (define query
(string-append " (string-append "
SELECT builds.id, build_servers.url, derivations.file_name, SELECT builds.id, build_servers.url, derivations.file_name,
@ -44,14 +61,12 @@ INNER JOIN
) AS latest_build_status ) AS latest_build_status
ON latest_build_status.build_id = builds.id ON latest_build_status.build_id = builds.id
" "
(if (list? build-statuses) (if (null? where-conditions)
(string-append ""
"WHERE latest_build_status.status IN (" (string-append
(string-join (map quote-string build-statuses) "WHERE "
",") (string-join where-conditions " AND ")))
")") "
"")
"
ORDER BY latest_build_status.timestamp DESC ORDER BY latest_build_status.timestamp DESC
LIMIT 100")) LIMIT 100"))

View file

@ -16,11 +16,13 @@
;;; <http://www.gnu.org/licenses/>. ;;; <http://www.gnu.org/licenses/>.
(define-module (guix-data-service web build controller) (define-module (guix-data-service web build controller)
#:use-module (srfi srfi-1)
#:use-module (ice-9 match) #:use-module (ice-9 match)
#:use-module (guix-data-service web render) #:use-module (guix-data-service web render)
#:use-module (guix-data-service web query-parameters) #:use-module (guix-data-service web query-parameters)
#:use-module (guix-data-service model build) #:use-module (guix-data-service model build)
#:use-module (guix-data-service model build-status) #:use-module (guix-data-service model build-status)
#:use-module (guix-data-service model build-server)
#:use-module (guix-data-service web build html) #:use-module (guix-data-service web build html)
#:export (build-controller)) #:export (build-controller))
@ -32,6 +34,20 @@
(string-append "unknown build status: " (string-append "unknown build status: "
status)))) status))))
(define (parse-build-server conn)
(lambda (v)
(let ((build-servers (select-build-servers conn)))
(or (any (match-lambda
((id url lookup-all-derivations?)
(if (eq? (string->number v)
id)
id
#f)))
build-servers)
(make-invalid-query-parameter
v
"unknown build server")))))
(define (build-controller request (define (build-controller request
method-and-path-components method-and-path-components
mime-types mime-types
@ -48,18 +64,26 @@
(let ((parsed-query-parameters (let ((parsed-query-parameters
(parse-query-parameters (parse-query-parameters
request request
`((build_status ,parse-build-status #:multi-value))))) `((build_status ,parse-build-status #:multi-value)
(build_server ,(parse-build-server conn) #:multi-value)))))
(if (any-invalid-query-parameters? parsed-query-parameters) (if (any-invalid-query-parameters? parsed-query-parameters)
(render-html (render-html
#:sxml (view-builds parsed-query-parameters #:sxml (view-builds parsed-query-parameters
build-status-strings build-status-strings
'() '()
'()
'())) '()))
(render-html (render-html
#:sxml (view-builds parsed-query-parameters #:sxml (view-builds parsed-query-parameters
build-status-strings build-status-strings
(map (match-lambda
((id url lookup-all-derivations)
(cons url id)))
(select-build-servers conn))
(select-build-stats conn) (select-build-stats conn)
(select-builds-with-context (select-builds-with-context
conn conn
(assq-ref parsed-query-parameters (assq-ref parsed-query-parameters
'build_status))))))) 'build_status)
(assq-ref parsed-query-parameters
'build_server)))))))

View file

@ -21,7 +21,11 @@
#:use-module (guix-data-service web view html) #:use-module (guix-data-service web view html)
#:export (view-builds)) #:export (view-builds))
(define (view-builds query-parameters build-status-strings stats builds) (define (view-builds query-parameters
build-status-strings
build-server-options
stats
builds)
(layout (layout
#:body #:body
`(,(header) `(,(header)
@ -64,6 +68,11 @@
build-status)) build-status))
build-status-strings) build-status-strings)
#:help-text "Return builds with these statuses.") #:help-text "Return builds with these statuses.")
,(form-horizontal-control
"Build server"
query-parameters
#:options build-server-options
#:help-text "Return builds from these build servers.")
(div (@ (class "form-group form-group-lg")) (div (@ (class "form-group form-group-lg"))
(div (@ (class "col-sm-offset-2 col-sm-10")) (div (@ (class "col-sm-offset-2 col-sm-10"))
(button (@ (type "submit") (button (@ (type "submit")