cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add "No lint warning changes" message to compare page

Browse source
This commit is contained in:
Christopher Baines 2019-10-05 11:11:22 +01:00
parent 9fc6dd08e6
commit 8019d2e687
1 changed files with 37 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

71
guix-data-service/web/view/html.scm
View file

@ -1789,41 +1789,44 @@
(div (div
(@ (class "col-sm-12")) (@ (class "col-sm-12"))
(h2 "Lint warnings") (h2 "Lint warnings")
,@(map ,@(if
(match-lambda (null? lint-warnings-data)
(((package-name package-version) . warnings) '((p "No lint warning changes"))
`((h4 ,package-name " (version: " ,package-version ")") (map
(table (match-lambda
(@ (class "table")) (((package-name package-version) . warnings)
(thead `((h4 ,package-name " (version: " ,package-version ")")
(tr (table
(th "") (@ (class "table"))
(th "Linter") (thead
(th "Message"))) (tr
(tbody (th "")
,@(map (match-lambda (th "Linter")
((lint-checker-name (th "Message")))
message (tbody
lint-checker-description ,@(map (match-lambda
lint-checker-network-dependent ((lint-checker-name
file line column-number ;; TODO Maybe use the location? message
change) lint-checker-description
lint-checker-network-dependent
file line column-number ;; TODO Maybe use the location?
change)
`(tr `(tr
(td (@ (class ,(if (string=? change "new") (td (@ (class ,(if (string=? change "new")
"text-danger" "text-danger"
"text-success")) "text-success"))
(style "font-weight: bold")) (style "font-weight: bold"))
,(if (string=? change "new") ,(if (string=? change "new")
"New warning" "New warning"
"Resolved warning")) "Resolved warning"))
(td (span (@ (style "font-family: monospace; display: block;")) (td (span (@ (style "font-family: monospace; display: block;"))
,lint-checker-name) ,lint-checker-name)
(p (@ (style "font-size: small; margin: 6px 0 0px;")) (p (@ (style "font-size: small; margin: 6px 0 0px;"))
,lint-checker-description)) ,lint-checker-description))
(td ,message)))) (td ,message))))
warnings)))))) warnings))))))
lint-warnings-data))))))) lint-warnings-data))))))))
(define (compare/derivations query-parameters (define (compare/derivations query-parameters
valid-systems valid-systems