cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve select-job-for-commit

Browse source 
It now returns #f or a list, rather than the empty list or a nested list.
This commit is contained in:
Christopher Baines 2020-10-09 19:31:51 +01:00
parent 51204aefca
commit 6023aa8caf
4 changed files with 44 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

20
guix-data-service/web/compare/html.scm
View file

@ -1034,26 +1034,26 @@
(div (@ (class "container"))
(h1 "Unknown commit")
,(if (invalid-query-parameter? base-commit)
(if (null? base-job)
`(p "No known revision with commit "
(strong (samp ,(invalid-query-parameter-value base-commit)))
".")
(if base-job
`(p "Revision "
(a (@ (href
,(string-append "/revision/"
(invalid-query-parameter-value base-commit))))
(strong (samp ,(invalid-query-parameter-value base-commit))))
" is queued for processing."))
" is queued for processing.")
`(p "No known revision with commit "
(strong (samp ,(invalid-query-parameter-value base-commit)))
"."))
'())
,(if (invalid-query-parameter? target-commit)
(if (null? target-job)
`(p "No known revision with commit "
(strong (samp ,(invalid-query-parameter-value target-commit)))
".")
(if target-job
`(p "Revision "
(a (@ (href
,(string-append "/revision/"
(invalid-query-parameter-value target-commit))))
(strong (samp ,(invalid-query-parameter-value target-commit))))
" is queued for processing."))
" is queued for processing.")
`(p "No known revision with commit "
(strong (samp ,(invalid-query-parameter-value target-commit)))
"."))
'())))))