cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cache the derivations that weren't deleted

Browse source 
When deleting derivations, as I think this might reduce the number of queries.
This commit is contained in:
Christopher Baines 2024-06-20 15:47:21 +01:00
parent 5e88a98c47
commit 530f58b59c
1 changed files with 20 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

28
guix-data-service/data-deletion.scm
View file

@ -552,6 +552,7 @@ DELETE FROM derivations WHERE id = $1"
1))) 1)))
(define deleted-count 0) (define deleted-count 0)
(define ignored-derivation-ids (make-hash-table))
(define channel (make-channel)) (define channel (make-channel))
(define (delete-batch conn) (define (delete-batch conn)
@ -589,7 +590,8 @@ WHERE NOT EXISTS (
(set! deleted-count 0) (set! deleted-count 0)
(for-each (for-each
(lambda (derivation-id) (lambda (derivation-id)
(put-message channel derivation-id)) (unless (hash-ref ignored-derivation-ids derivation-id)
(put-message channel derivation-id)))
derivations)) derivations))
(simple-format (current-error-port) (simple-format (current-error-port)
@ -636,6 +638,11 @@ SET CONSTRAINTS derivations_by_output_details_set_derivation_id_fkey DEFERRED")
0)))) 0))))
(when (= 0 val)
(hash-set! ignored-derivation-ids
derivation-id
#t))
;; This is safe as all fibers are in the same ;; This is safe as all fibers are in the same
;; thread and cooperative. ;; thread and cooperative.
(set! deleted-count (set! deleted-count
@ -654,13 +661,18 @@ SET CONSTRAINTS derivations_by_output_details_set_derivation_id_fkey DEFERRED")
(let ((batch-deleted-count (delete-batch conn))) (let ((batch-deleted-count (delete-batch conn)))
(if (eq? 0 batch-deleted-count) (if (eq? 0 batch-deleted-count)
(begin (begin
(with-time-logging (hash-clear! ignored-derivation-ids)
"Deleting unused derivation_source_files entries" (let ((batch-deleted-count (delete-batch conn)))
(delete-unreferenced-derivations-source-files conn)) (if (= 0 batch-deleted-count)
(simple-format (begin
(current-output-port) (with-time-logging
"Finished deleting derivations, deleted ~A in total\n" "Deleting unused derivation_source_files entries"
total-deleted)) (delete-unreferenced-derivations-source-files conn))
(simple-format
(current-output-port)
"Finished deleting derivations, deleted ~A in total\n"
total-deleted))
(loop (+ total-deleted batch-deleted-count)))))
(loop (+ total-deleted batch-deleted-count)))))))) (loop (+ total-deleted batch-deleted-count))))))))
#:hz 0 #:hz 0
#:parallelism 1)) #:parallelism 1))