cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use advisory locks to avoid deadlocks during data deletion

Browse source 
In the case where multiple data deleting processes end up running at the same
time.
This commit is contained in:
Christopher Baines 2022-11-28 10:26:46 +00:00
parent ad93a780d3
commit 38b3657013
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
guix-data-service/data-deletion.scm
View file

@ -206,6 +206,10 @@ WHERE id IN (
(with-postgresql-transaction (with-postgresql-transaction
conn conn
(lambda (conn) (lambda (conn)
(obtain-advisory-transaction-lock
conn
'delete-revisions-from-branch)
(delete-from-git-commits conn) (delete-from-git-commits conn)
(delete-jobs conn) (delete-jobs conn)
@ -538,6 +542,10 @@ WHERE NOT EXISTS (
(with-postgresql-transaction (with-postgresql-transaction
conn conn
(lambda (conn) (lambda (conn)
(obtain-advisory-transaction-lock
conn
'delete-unreferenced-derivations)
(exec-query (exec-query
conn conn
" "