Fix type issues with the location ids

On one code path, they were handled as numbers, whereas elsewhere they were
handled as strings. This led to the package-metadata code trying to insert
duplicate entries.

Instead, just handle them as strings everywhere.

guix-data-service/model/location.scm

@@ -42,13 +42,11 @@
                         (list file
                               (number->string line)
                               (number->string column)))
-       (((id))
+       (((id)) id)
-        (string->number id))
        (()
-        (string->number
         (caar
          (exec-query conn
                      insert-location
                      (list file
                            (number->string line)
-                            (number->string column))))))))))
+                           (number->string column)))))))))

guix-data-service/model/package-metadata.scm

@@ -92,7 +92,7 @@ WHERE packages.id IN (
                            (value->quoted-string-or-null synopsis) ","
                            (value->quoted-string-or-null description) ","
                            (value->quoted-string-or-null home_page) ","
-                           (number->string location_id)
+                           location_id
                            ")")))
                        metadata-rows)
                   ",")

tests/model-package-metadata.scm

@@ -34,6 +34,18 @@
                 conn
                 (list mock-inferior-package-foo))
              ((x) (string? x))))
+         #:always-rollback? #t))
+
+      (with-postgresql-transaction
+       conn
+       (lambda (conn)
+         (test-equal "inferior-packages->package-metadata-ids"
+           (inferior-packages->package-metadata-ids
+            conn
+            (list mock-inferior-package-foo))
+           (inferior-packages->package-metadata-ids
+            conn
+            (list mock-inferior-package-foo)))
          #:always-rollback? #t))))))
 
 (test-end)