Handle unknown requests better within controllers

guix-data-service/web/compare/controller.scm

@@ -114,7 +114,8 @@
                 (target_commit ,(parse-commit conn) #:required)))))
        (render-compare/packages mime-types
                                 conn
-                                parsed-query-parameters)))))
+                                parsed-query-parameters)))
+    (_ #f)))
 
 (define (render-compare mime-types
                         conn

guix-data-service/web/controller.scm

@@ -202,11 +202,12 @@
     (uri-path (request-uri request)))
 
   (define (delegate-to f)
-    (f request
+    (or (f request
-       method-and-path-components
+           method-and-path-components
-       mime-types
+           mime-types
-       body
+           body
-       conn))
+           conn)
+        (not-found (request-uri request))))
 
   (match method-and-path-components
     (('GET)

guix-data-service/web/jobs/controller.scm

@@ -44,7 +44,8 @@
        (render-job mime-types
                    conn
                    job-id
-                   parsed-query-parameters)))))
+                   parsed-query-parameters)))
+    (_ #f)))
 
 (define (render-jobs mime-types conn)
   (render-html

guix-data-service/web/repository/controller.scm

@@ -207,4 +207,5 @@
                                              "/latest-processed-revision"))
            (render-unknown-revision mime-types
                                     conn
-                                    commit-hash))))))
+                                    commit-hash))))
+    (_ #f)))

guix-data-service/web/revision/controller.scm

@@ -136,7 +136,8 @@
                                           #:path-base path))
          (render-unknown-revision mime-types
                                   conn
-                                  commit-hash)))))
+                                  commit-hash)))
+    (_ #f)))
 
 (define (texinfo->variants-alist s)
   (let ((stexi (texi-fragment->stexi s)))