cbaines/guix-data-service
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Implement version history using the derivations table

Browse source 
Rather than having two big tables looking at the history, just use the
derivations table as it has all the information.

This will allow deleting the package_versions_by_guix_revision_range table
which should help save time when importing revisions, and reduce the size of
the database.
This commit is contained in:
Christopher Baines 2020-03-24 20:17:18 +00:00
parent 96bf658dfc
commit 102f7a0536
1 changed files with 31 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

16
guix-data-service/model/package.scm
View file

@ -230,12 +230,19 @@ ORDER BY version")
(exec-query
conn
"
SELECT DISTINCT
data1.package_version,
first_value(first_guix_revision_commit) OVER version_window AS first_guix_revision_commit,
first_value(first_datetime) OVER version_window AS first_datetime,
last_value(last_guix_revision_commit) OVER version_window AS last_guix_revision_commit,
last_value(last_datetime) OVER version_window AS last_datetime
FROM (
SELECT package_version,
first_guix_revisions.commit AS first_guix_revision_commit,
first_git_branches.datetime AS first_datetime,
last_guix_revisions.commit AS last_guix_revision_commit,
last_git_branches.datetime AS last_datetime
FROM package_versions_by_guix_revision_range
FROM package_derivations_by_guix_revision_range
INNER JOIN guix_revisions AS first_guix_revisions
ON first_guix_revision_id = first_guix_revisions.id
INNER JOIN git_branches AS first_git_branches
@ -247,10 +254,13 @@ INNER JOIN git_branches AS last_git_branches
ON last_guix_revisions.git_repository_id = last_git_branches.git_repository_id
AND last_guix_revisions.commit = last_git_branches.commit
WHERE package_name = $1
AND package_versions_by_guix_revision_range.git_repository_id = $2
AND package_versions_by_guix_revision_range.branch_name = $3
AND package_derivations_by_guix_revision_range.git_repository_id = $2
AND package_derivations_by_guix_revision_range.branch_name = $3
AND first_git_branches.name = $3
AND last_git_branches.name = $3
ORDER BY first_datetime ASC, package_version DESC
) AS data1
WINDOW version_window AS (PARTITION BY package_version)
ORDER BY first_datetime DESC, package_version DESC"
(list package-name
(number->string git-repository-id)