Close the load revision inferior prior to inserting data

This means that the lock can be acquired after closing the inferior, freeing
the large amount of memory that the inferior process is probably using.
This commit is contained in:
Christopher Baines 2022-03-11 13:07:34 +00:00
parent df4e0a7a61
commit 097e22ab5e
4 changed files with 183 additions and 138 deletions

View file

@ -5,6 +5,7 @@
#:use-module (guix utils)
#:use-module (guix tests)
#:use-module (tests mock-inferior)
#:use-module (guix-data-service model utils)
#:use-module (guix-data-service model license)
#:use-module (guix-data-service model license-set)
#:use-module (guix-data-service model package)
@ -45,16 +46,18 @@
(list mock-inferior-package-foo
mock-inferior-package-foo-2))
(mock
((guix-data-service model package-metadata)
inferior-packages->translated-package-descriptions-and-synopsis
(lambda (inferior inferior-package)
(cons `(("en_US.UTF-8" . "Fake synopsis"))
`(("en_US.UTF-8" . "Fake description")))))
(define mock-package-metadata
(map (lambda (mock-inf-pkg)
(list
(mock-inferior-package-home-page mock-inf-pkg)
(mock-inferior-package-location mock-inf-pkg)
`(("en_US.UTF-8" . "Fake synopsis"))
`(("en_US.UTF-8" . "Fake description"))))
mock-inferior-packages))
(with-mock-inferior-packages
(lambda ()
(use-modules (guix-data-service model utils)
(guix-data-service model package)
(use-modules (guix-data-service model package)
(guix-data-service model git-repository)
(guix-data-service model guix-revision)
(guix-data-service model package-metadata))
@ -68,11 +71,11 @@
conn
(lambda (conn)
(test-assert "inferior-packages->package-ids works once"
(let ((package-metadata-ids (inferior-packages->package-metadata-ids
conn
""
mock-inferior-packages
(test-license-set-ids conn)))
(let ((package-metadata-ids
(inferior-packages->package-metadata-ids
conn
mock-package-metadata
(test-license-set-ids conn)))
(package-replacement-package-ids
(make-list (length mock-inferior-packages)
(cons "integer" NULL))))
@ -88,11 +91,11 @@
(with-postgresql-transaction
conn
(lambda (conn)
(let ((package-metadata-ids (inferior-packages->package-metadata-ids
conn
""
mock-inferior-packages
(test-license-set-ids conn)))
(let ((package-metadata-ids
(inferior-packages->package-metadata-ids
conn
mock-package-metadata
(test-license-set-ids conn)))
(package-replacement-package-ids
(make-list (length mock-inferior-packages)
(cons "integer" NULL))))
@ -109,6 +112,6 @@
(map mock-inferior-package-version mock-inferior-packages)
package-metadata-ids
package-replacement-package-ids)))))
#:always-rollback? #t))))))
#:always-rollback? #t)))))
(test-end)