From c751031a263a2adc00149c5c8a05446bbdfc2c12 Mon Sep 17 00:00:00 2001 From: Christopher Baines Date: Sat, 21 Nov 2020 16:49:58 +0000 Subject: [PATCH] Avoid crashing when no compare arguments are provided --- guix-data-service/web/compare/controller.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/guix-data-service/web/compare/controller.scm b/guix-data-service/web/compare/controller.scm index df7e89a..5edd922 100644 --- a/guix-data-service/web/compare/controller.scm +++ b/guix-data-service/web/compare/controller.scm @@ -182,14 +182,16 @@ (($ value) (with-thread-postgresql-connection (lambda (conn) - (select-job-for-commit conn value)))) + (and (string? value) + (select-job-for-commit conn value))))) (_ #f))) (target-job (match (assq-ref query-parameters 'target_commit) (($ value) (with-thread-postgresql-connection (lambda (conn) - (select-job-for-commit conn value)))) + (and (string? value) + (select-job-for-commit conn value))))) (_ #f)))) (case (most-appropriate-mime-type '(application/json text/html)