From 1e0332136ecaaeb3bc927a62450f8066f2f06ecd Mon Sep 17 00:00:00 2001 From: Christopher Baines Date: Mon, 13 Jul 2020 19:12:09 +0100 Subject: [PATCH] Fix rendering the required failed builds for builds by id Use the derivation-file-name from the database, rather than the query parameter. --- .../web/build-server/controller.scm | 28 ++++++++++--------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/guix-data-service/web/build-server/controller.scm b/guix-data-service/web/build-server/controller.scm index 6fa5385..8eb5e7a 100644 --- a/guix-data-service/web/build-server/controller.scm +++ b/guix-data-service/web/build-server/controller.scm @@ -70,19 +70,21 @@ #:sxml (view-build query-parameters build - (if (member - (assoc-ref (last (vector->list (third build))) - "status") - '("failed-dependency" - "scheduled")) ; scheduled, because the - ; guix-build-coordinator doesn't - ; mark builds as - ; failed-dependency - (select-required-builds-that-failed - conn - build-server-id - derivation-file-name) - #f))) + (match build + ((url derivation-file-name statuses) + (if (member + (assoc-ref (last (vector->list statuses)) + "status") + '("failed-dependency" + "scheduled")) ; scheduled, because the + ; guix-build-coordinator + ; doesn't mark builds as + ; failed-dependency + (select-required-builds-that-failed + conn + build-server-id + derivation-file-name) + #f))))) (render-html #:sxml (general-not-found "Build not found"