From bf28a0deb9a2ff9ee82a07bcce8183c5e1ed4f20 Mon Sep 17 00:00:00 2001 From: Christopher Baines Date: Wed, 19 Nov 2025 12:31:45 +0000 Subject: [PATCH] Improve naming for the gc metrics --- prometheus.scm | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/prometheus.scm b/prometheus.scm index 7332d57..83061a7 100644 --- a/prometheus.scm +++ b/prometheus.scm @@ -555,24 +555,28 @@ This procedure takes care of atomically replacing the file." (define (get-gc-metrics-updater registry) (define metrics `((gc-time-taken - . ,(make-gauge-metric registry "guile_gc_time_taken")) + . ,(make-gauge-metric registry "guile_gc_time_taken_seconds")) (heap-size - . ,(make-gauge-metric registry "guile_heap_size")) + . ,(make-gauge-metric registry "guile_heap_bytes")) (heap-free-size - . ,(make-gauge-metric registry "guile_heap_free_size")) + . ,(make-gauge-metric registry "guile_heap_free_bytes")) (heap-total-allocated - . ,(make-gauge-metric registry "guile_heap_total_allocated")) + . ,(make-gauge-metric registry "guile_heap_total_allocated_bytes")) (heap-allocated-since-gc - . ,(make-gauge-metric registry "guile_allocated_since_gc")) + . ,(make-gauge-metric registry "guile_allocated_since_gc_bytes")) (protected-objects - . ,(make-gauge-metric registry "guile_gc_protected_objects")) + . ,(make-gauge-metric registry "guile_gc_protected_objects_total")) (gc-times - . ,(make-gauge-metric registry "guile_gc_times")))) + . ,(make-gauge-metric registry "guile_gc_times_total")))) (lambda () (let ((stats (gc-stats))) (for-each (match-lambda + (('gc-time-taken . metric) + (metric-set metric + (/ (assq-ref stats 'gc-time-taken) + internal-time-units-per-second))) ((name . metric) (let ((value (assq-ref stats name))) (metric-set metric value))))